noblepaul commented on code in PR #2438:
URL: https://github.com/apache/solr/pull/2438#discussion_r1623666372
##########
solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java:
##########
@@ -105,14 +102,11 @@ public void testSimple() throws Exception {
assertEquals(10, rslt.getResults().size());
+ String SYNTHETIC_COLLECTION =
CoordinatorHttpSolrCall.getSyntheticCollectionName("conf");
DocCollection collection =
cluster.getSolrClient().getClusterStateProvider().getCollection(SYNTHETIC_COLLECTION);
- assertNotNull(collection);
-
- Set<String> expectedNodes = new HashSet<>();
- expectedNodes.add(coordinatorJetty.getNodeName());
- collection.forEachReplica((s, replica) ->
expectedNodes.remove(replica.getNodeName()));
- assertTrue(expectedNodes.isEmpty());
+ // this should be empty as synthetic collection does not register with ZK
+ assertNull(collection);
Review Comment:
I think we should invoke the core API command to confirm a synthetic core is
created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
