patsonluk commented on code in PR #2438:
URL: https://github.com/apache/solr/pull/2438#discussion_r1625146698
##########
solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java:
##########
@@ -105,14 +102,11 @@ public void testSimple() throws Exception {
assertEquals(10, rslt.getResults().size());
+ String SYNTHETIC_COLLECTION =
CoordinatorHttpSolrCall.getSyntheticCollectionName("conf");
DocCollection collection =
cluster.getSolrClient().getClusterStateProvider().getCollection(SYNTHETIC_COLLECTION);
- assertNotNull(collection);
-
- Set<String> expectedNodes = new HashSet<>();
- expectedNodes.add(coordinatorJetty.getNodeName());
- collection.forEachReplica((s, replica) ->
expectedNodes.remove(replica.getNodeName()));
- assertTrue(expectedNodes.isEmpty());
+ // this should be empty as synthetic collection does not register with ZK
+ assertNull(collection);
Review Comment:
Good call!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
