dsmiley commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1629870347
##########
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java:
##########
@@ -557,7 +558,7 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
while (rb.outgoing.size() == 0) {
ShardResponse srsp =
tolerant
- ? shardHandler1.takeCompletedIncludingErrors()
+ ?
shardHandler1.takeCompletedIncludingErrorsWithTimeout(maxTimeAllowed)
Review Comment:
shouldn't it be the *remaining* time allowed?
For example see:
https://github.com/apache/solr/blob/53a25d1b5d02dd234358264420884b8eed204b56/solr/core/src/java/org/apache/solr/search/TimeAllowedLimit.java#L53
Hmm; ideally it'd be a one-liner to get the remaining time allowed; maybe a
utility method should be somewhere for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
