hiteshk25 commented on code in PR #2493: URL: https://github.com/apache/solr/pull/2493#discussion_r1635595108
########## solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java: ########## @@ -557,7 +558,7 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp) throw while (rb.outgoing.size() == 0) { ShardResponse srsp = tolerant - ? shardHandler1.takeCompletedIncludingErrors() + ? shardHandler1.takeCompletedIncludingErrorsWithTimeout(maxTimeAllowed) Review Comment: Thanks @dsmiley , I have updated your feedback. Also @gus-asf please let me what you think about it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org