dsmiley commented on PR #2548: URL: https://github.com/apache/solr/pull/2548#issuecomment-2207708444
> Surprisingly clean and concise refactoring! Thanks :-). There were a few rounds of attempts before getting at this. > Did you run the ./jmh.sh CloudIndexing benchmark on it? oh, great suggestion. I'll do that as the next step; I remember you used that when you did the earlier VersionBucket change. FYI I removed the documentation setting for the former timeout without replacement of the new. I think it's even more unlikely that someone would set it. When it was a "bucket" there was a reason and the docs elaborated on that reason. It's reasonable to by default block indefinitely for a concurrent update _for the same doc_. I'll get another opinion on this once I see the benchmarks look good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
