iamsanjay commented on PR #2528: URL: https://github.com/apache/solr/pull/2528#issuecomment-2208116261
I’d like to resolve this issue, but before that, we need to address issue #2539. A test case failed on a Windows machine because of the backslash character. URI is stricter compared to URL, which raises some concerns about this code change. Could there be more failures like this if we merge this code into 9_x? I am going to point out all the main core classes (not the test cases) where we swapped URL with URI. I’d really appreciate any feedback on whether you think this change might cause issues, especially with passing a string that could contain special characters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
