epugh commented on PR #2528: URL: https://github.com/apache/solr/pull/2528#issuecomment-2210664506
> Mainly, we are looking for any special character that could fail the URI parsing. So far there is one example from the past where passing caret(^) symbol in the query params failed it, and now recently with passing backslash() in the path query params. I don't think I quite understand the thrust of your comment/question. We should be properly handling all URI to obey the stricket definition, and if we aren't, we should figure out why and fix it right? I think the changes you've made here are right, and our testing should pick if there are other places that URI being stricter than URL causes an issue then we fix them as we go? At least as far as I know there aren't any special nuances that would cause problems, but again, I only know parts of Solr's code base! I suppose if we had the ability to "fuzz" our inputs we could proactively test out all the variations of the old URL inputs to test them, but that feels like a major undertaking! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
