malliaridis opened a new pull request, #2577: URL: https://github.com/apache/solr/pull/2577
https://issues.apache.org/jira/browse/SOLR-16824 # Description This PR replaces additional deprecated single-dash arguments that were depricated in previous PRs. # Solution Please provide a short description of the approach taken to implement your solution. # Tests Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem. # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) # Additional Notes / TODOs: The following list contains the arguments that were looked up: | Argument | Replaced With | `main` migrated | `branch_9x` migrated | | --- | --- | :-: | :-: | | `-help` | `--help` or `-h` | ✅ | ❓ | | `-version` | `--version` or `-v`* | ❓ | ❓ | | `-foreground` | `--foreground` | ✅ | ❓ | | `-cloud` | `--cloud` | ✅ | ❓ | | `-host` | `--host` | ✅ | ❓ | | `-port` | `--port` | ✅ | ❓ | | `-scheme` | `--scheme` | ✅ | ❓ | | `-zkHost` | `--zk-host` | ✅ | ❓ | | `--zkHost` | `--zk-host` | ✅ | ❓ | | `-solrUrl` | `--solr-url` | ✅ | ❓ | | `-solr.home` | `--solr-home` | ✅ | ❓ | | `-solr-home` | `--solr-home` | ✅ | ❓ | | `-data.home` | `--data-home` | ✅ | ❓ | | `-data-home` | `--data-home` | ✅ | ❓ | | `-confname` | `--conf-name` | ✅ | ❓ | | `-confdir` | `--conf-dir` | ✅ | ❓ | | `-collection` | `--collection`* | ❓ | ❓ | | `-collections` | `--collections`* | ❓ | ❓ | | `-verbose` | `--verbose`* | ❓ | ❓ | | `-credentials` | `--credentials`* | ❓ | ❓ | | `-prompt` | `--prompt`* | ✅ | ❓ | | `-noprompt` | `--no-prompt` | ✅ | ❓ | | `--noprompt` | `--no-prompt` | ✅ | ❓ | | `-action` | `--action` | ✅ | ❓ | | `-property` | `--property` | ✅ | ❓ | | `-value` | `--value` | ✅* | ❓ | | `-solrIncludeFile` | `--solr-include-file` | ✅ | ❓ | | `-example` | `--example` | ✅ | ❓ | | `-key` | `--key` | ✅ | ❓ | | `-all` | `--all` | ✅ | ❓ | | `-force` | `--force` | ✅ | ❓ | | `-out` | `--out` | ✅ | ❓ | While editing I noticed that: - Between `-noprompt`, `--noprompt` and `--no-prompt`, which option will be maintained? - [ ] There are occurences that have not been replaced - Some arguments are not present in `bin/solr` nor `bin/solr.cmd` (e.g. `--collections`) - [ ] Clarify if `-collections` is also deprecated and should be replaced with `--collections` - [ ] Clarify the usage of `-collection` (was that a typo ir is there an argument called "collection"?) - [ ] Clarify difference between `-V` and `-v` - [ ] Both arguments long form is `--verbose`, is this a problem? - [ ] `--value` for setting property value does also use `-v` as short form, is this a problem? - [ ] `bin/solr.cmd` supports `-confdir`, but `bin/solr` does not, should this be fixed? - [ ] `bin/solr` supports `-solr.home`, but `bin/solr.cmd` does not (same applies for -data.home), should this be fixed? - There are overlapping short arguments - [ ] `-d` is used for `--dir` and `--conf-dir`, is this fine? Overlapping options: - Overlapping of -d definition for —dir and —conf-dir, is this fine? - Overlapping of -s definition for —solr-url and —solr-home, is this fine? The multicharacter command url is still used as -url and resolves to —solr-udpate-url (post tool) solr/docker/scripts/docker-entrypoint.sh - Line 37 to 40: Is this still correct? solr/ref-guide/modules/deployment-guide/pages/jvm-settings.adoc - Line 66 “java -help”? solr/ref-guide/modules/deployment-guide/pages/enabling-ssl.adoc - Invalid character in 252 solr/ref-guide/modules/deployment-guide/pages/solr-control-script-reference.adoc - Line 1119 Is -scheme now —scheme? (see also solr/bin/solr.cmd:1390) solr/bin/instal_solr_service.sh - Line 171 “-help|-usage)” -> Should this be -h|—help|—usage) instead? solr/bin/solr - Line 938 Should we not support —collection too? solr/bin/solr.cmd - Line 258 Should we also have —version as option? - Line 295 Duplicate line (removed) - Line 530 and follow: Do we have to cover always both (- and —) options in the list? - Line 534 Should we also have “—help”? - Line 539 Should we also have “-foreground”? - Line 541 Should we also have “-verbose”? - Line 547 Should we also have “-dir”? - Line 545 Should we also have “—cloud”? - Line 1409 and follow: Do we have to cover additional options (like —conf-dir and —help)? - Line 1648 and follow: Do we have to cover additional options (—help and -h)? solr/core/test/org.apache.solr.cli.TestSolrCLIRunExample.java - Line 117: Should -cloud also be included in the checks? solr/core/main/org.apache.solr.cli.RunExampleTool.java - Line 615-620: The arguments are mixed (written out and not), should this be unified? solr/prometheus-exporter/main/org.apache.solr.prometheus.exporter.SolrExporter.java - class properties called ARG_***_FLAGS: Should they include the single-dash option too? solr/core/test/org.apache.solr.cli.TestExportTool.java - testWithBasicAuth method uses only single dashed arguments solr/core/test/org.apache.solr.cli.DeleteToolTest.java - testFailsToDeleteProtectedCollection method uses only single dashed arguments - testDeleteCollectionWithBasicAuth method uses only single dashed arguments solr/core/test/org.apache.solr.cli.CreateToolTest.java - testCreateCollectionWithBasicAuth method uses only single dashed arguments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
