epugh commented on code in PR #2577: URL: https://github.com/apache/solr/pull/2577#discussion_r1686856221
########## solr/core/src/test/org/apache/solr/cli/AuthToolTest.java: ########## @@ -70,7 +70,7 @@ public void testEnableAuth() throws Exception { dir.toAbsolutePath().toString(), "--solr-include-file", solrIncludeFile.toAbsolutePath().toString(), - "-credentials", Review Comment: after dinking around with the code, I realize that the `-` versus `--` is dealt with by commons-cli, and we don't need to test that logic! I will look for a place to introduce testing of deprecated Option versus current Option... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org