dsmiley commented on PR #2571: URL: https://github.com/apache/solr/pull/2571#issuecomment-2241266022
I love the sequence diagrams! What tool did you use to draw it? RE aliases: I was anticipating that this PR might regress the alias functionality. But CloudHttp2SolrClientTest.testAliasHandling passes (as do all tests), and it uses the HTTP based CSP, so I suppose there's no down-side to any current user with this PR? BTW, CloudHttp2SolrClientTest.getRandomClient is not doing what it should be doing. Based on the commented code, I suspect the last person touching it (Dat) accidentally commented out the randomization. I ran this test locally using both clients and it passes both ways. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
