dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1687117265
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##########
@@ -262,12 +263,18 @@ public void testHttpCSPPerf() throws Exception {
httpBasedCloudSolrClient.add(COLLECTION, doc);
httpBasedCloudSolrClient.commit(COLLECTION);
+ Pattern patternWithCollection =
+ Pattern.compile(
+
"path=/admin/collections.*params=\\{[^}]*action=CLUSTERSTATUS[^}]*collection=[^&}]+[^}]*\\}");
+
+ Pattern patternWithoutCollection =
+ Pattern.compile(
+
"path=/admin/collections.*params=\\{[^}]*action=CLUSTERSTATUS(?![^}]*collection=)[^}]*\\}");
Review Comment:
Okay. Albeit, these regex's are obtuse. It'd be nice if LogListener had a
`predicate` method taking `Predicate<String>` then you'd have something more
readable like contains this and doesn't contain that. Ah well. Feel free to
ignore this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
