patsonluk commented on code in PR #2607:
URL: https://github.com/apache/solr/pull/2607#discussion_r1700444070
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -2056,7 +2056,7 @@ public void reload(String name, UUID coreId) {
newCore = core.reload(coreConfig);
DocCollection docCollection = null;
- if (getZkController() != null) {
+ if (getZkController() != null && !newCore.isSynthetic()) {
docCollection =
getZkController().getClusterState().getCollection(cd.getCollectionName());
// turn off indexing now, before the new core is registered
if (docCollection.getBool(ZkStateReader.READ_ONLY, false)) {
Review Comment:
I do like your suggestion as we can avoid introduction of `isSynthetic` and
SolrCore/CoreContainer can remain unaware of the synthetic collection, which is
a major ➕ !
Perhaps we can get some input from @dsmiley on this as well? 😊 🙏🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
