dsmiley commented on code in PR #2607:
URL: https://github.com/apache/solr/pull/2607#discussion_r1699239949
##########
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##########
@@ -805,6 +792,24 @@ public SolrCore reload(ConfigSet coreConfig) throws
IOException {
}
}
+ /**
+ * Clones the current core for core reload, with the provided CoreDescriptor
and ConfigSet.
+ *
+ * @return the cloned core to be used for SolrCore#load
+ */
+ protected SolrCore cloneAsReloadCore(
Review Comment:
the name of this method reads weird to me... maybe cloneForReloadedCore
sounds better
##########
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##########
@@ -805,6 +792,24 @@ public SolrCore reload(ConfigSet coreConfig) throws
IOException {
}
}
+ /**
+ * Clones the current core for core reload, with the provided CoreDescriptor
and ConfigSet.
+ *
+ * @return the cloned core to be used for SolrCore#load
Review Comment:
Not for SolrCore#reload but SolrCore#reload -- you could actually link to
the method instead BTW
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
