dsmiley commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1702323807
########## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ########## @@ -77,12 +75,13 @@ public class CollectionPropertiesZkStateReader implements Closeable { private final ExecutorService notifications = ExecutorUtil.newMDCAwareCachedThreadPool("cachecleaner"); - // only kept to identify if the cleaner has already been started. - private Future<?> collectionPropsCacheCleaner; + // identify if the cleaner has already been started. + private final AtomicBoolean collectionPropsCacheCleanerInitialized = new AtomicBoolean(false); Review Comment: it'd just be an interrupt & join (2 lines); no? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org