dsmiley commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1706392465
########## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ########## @@ -300,10 +313,11 @@ private VersionedCollectionProps fetchCollectionProperties(String collection, Wa throws KeeperException, InterruptedException { final String znodePath = getCollectionPropsPath(collection); // lazy init cache cleaner once we know someone is using collection properties. - if (collectionPropsCacheCleaner == null) { - synchronized (zkStateReader.getUpdateLock()) { // Double-checked locking - if (collectionPropsCacheCleaner == null) { - collectionPropsCacheCleaner = notifications.submit(new CacheCleaner()); + if (cacheCleanerThread == null) { + synchronized (this) { + if (cacheCleanerThread == null) { Review Comment: If you want. But I think the best solution reflecting the pattern/need for this cache cleaner is a ScheduledExecutorService and no extra state var. all ExecutorService's *have* state or could use null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org