malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708054252
########## gradle/libs.versions.toml: ########## @@ -0,0 +1,65 @@ +[versions] Review Comment: I am currently working on a migration to use version catalogs in the entire project (outside this POC). I will probably discuss version catalogs soon in the mailing list. I saw it in the Lucene project and I am using version catalogs on personal projects too, so it was the easiest and quickest way to get started. But it should definitely be either-or, not both present like in this POC. See https://github.com/apache/lucene/pull/13484. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
