malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708060169
########## solr/compose-ui/src/commonMain/composeResources/font/firacode-variable.ttf: ########## Review Comment: It is possible to use a dependency and load the fonts "dynamically" if there is one for Compose MP (I think I saw something). I am not a fan to version fonts either, I just did it here (I have no reason why, I just tried to mitigate the look and feel from the new designs). And using custom fonts in web has always been a "complicated" topic (and already caused some issues), so avoiding it completely may also prove to be a better option. So this is definitely something that needs further investigation and should be addressed. Good thing you pointed that out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
