dsmiley commented on code in PR #2611:
URL: https://github.com/apache/solr/pull/2611#discussion_r1708536459
##########
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java:
##########
@@ -391,13 +383,7 @@ public void run() {
private class CacheCleaner implements Runnable {
@Override
public void run() {
- while (!Thread.interrupted()) {
- try {
- Thread.sleep(60000);
- } catch (InterruptedException e) {
- // Executor shutdown will send us an interrupt
- break;
- }
+ if (!closed) {
Review Comment:
don't even need this condition. The work is not contingent on being closed
or not AFAICT. Even if it did, the pool is going to be closed when it's being
shut down so it's okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
