epugh commented on code in PR #2645:
URL: https://github.com/apache/solr/pull/2645#discussion_r1716669278
##########
solr/core/src/java/org/apache/solr/handler/admin/ColStatus.java:
##########
@@ -93,8 +93,14 @@ public void getColStatus(NamedList<Object> results) {
if (withRawSizeSummary || withRawSizeDetails) {
withRawSizeInfo = true;
}
- if (withFieldInfo || withSizeInfo) {
- withSegments = true;
+ boolean getSegments = false;
Review Comment:
maybe kind of bikeshedding, but what about `requireSegments`? Or
`segmentsNeeded`? `getSegments` kind of looks like a method to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
