iamsanjay commented on PR #2665:
URL: https://github.com/apache/solr/pull/2665#issuecomment-2310129670
Thanks @dweiss for pointing that out. To test that, I added below code to
one of the test case.
```
public void testFailure() {
if(random().nextBoolean()) {
assertFalse(true);
}
}
```
```
retry {
maxRetries = 20
maxFailures = 20
failOnPassedAfterRetry = false
}
```
If the same seed wasn't used, or if there was no seed at all, any retry
could set nextBoolean to false, causing the test to pass. However, I observed
that once the test failed, it kept failing 20 times more and stop there because
it couldn't go beyond that limit, as maxFailures was configured. I've also
attached the test output where you can see the same seed repeating!
[TEST-org.apache.solr.util.TestSolrVersion.txt](https://github.com/user-attachments/files/16748711/TEST-org.apache.solr.util.TestSolrVersion.txt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
