iamsanjay commented on code in PR #2665:
URL: https://github.com/apache/solr/pull/2665#discussion_r1733958205
##########
gradle/testing/defaults-tests.gradle:
##########
@@ -181,6 +181,13 @@ allprojects {
// Print some diagnostics about locations used.
logger.info("Test folders for {}: cwd={}, tmp={}", project.path,
testsCwd, testsTmpDir)
}
+ if(isCIBuild) {
+ retry {
+ maxRetries = 20
+ maxFailures = 20
Review Comment:
What I initially thought was this?
The maxFailure setting acts as a cumulative failure limit. If it's set to
10, and you have 5 test cases fail, in the worst case scenario where retries
also fail, it might retry the first 3 test cases 3 times, the 4th one only
once, and skip the 5th one since the maxFailure limit would be reached. And I
have seen around 4-5 test cases failing the recent build. I thought It would be
great to give all the test cases a chance. With 20, we could re-run, in worst
case, 7 tests.
But I am also fine with 10 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
