iamsanjay commented on PR #2689: URL: https://github.com/apache/solr/pull/2689#issuecomment-2326571320
I don't think we should extend SolrClientCache. While we're looking for a new home for the default HTTP client and have agreed that UpdateShardHandler isn't the right place, the same applies to SolrClientCache. Extending SolrClientCache implies that we intend to use some of its functionality, but it operates quite differently. `SolrClientCache` creates clients based on URLs and checks if a client already exists whenever a class needs one; if not, it creates a new one—hence the suffix "Cache." With the move to HTTP/2, we don't really need that functionality anymore. Therefore, I don't think extending SolrClientCache is a good idea. Additionally, the name doesn't suit the current HTTP/2 client since there's no cache—it's more of a provider, in my opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
