dsmiley commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1745826245
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -2563,6 +2581,11 @@ public PlacementPluginFactory<? extends
PlacementPluginConfig> getPlacementPlugi
return this.distributedCollectionCommandRunner;
}
+ /** Returns default http solr client. */
+ public SolrClient getDefaultHttpClient() {
Review Comment:
Since this is specifically an HttpClient (it's in the method name!) I think
it's totally reasonable to return this type. Casting is sad; it's a code
smell. reqeustAsync is somewhat new so you want see it called too many times.
It remains to be seen what the solution to
[SOLR-17256](https://issues.apache.org/jira/browse/SOLR-17256) is but I could
imagine a new request method containing the URL; if so then yet another reason
to return a specific type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
