gerlowskija opened a new pull request, #2714: URL: https://github.com/apache/solr/pull/2714
https://issues.apache.org/jira/browse/SOLR-17256 # Description Mutating SolrRequest objects as setBasePath does is a bad practice, as the modification isn't documented and many users expect to reuse these request objects across multiple requests. # Solution This PoC commit demoes one potential alternative: a `SolrClient.requestWithBaseUrl` method that temporarily overrides the base URL and then executes a caller-provided lambda. e.g. ``` var updateRsp = client.requestWithBaseUrl(url, (c) -> req.process(c)) ``` This is a bit more involved than simply adding a new URL-consuming 'request' method, but helps us steer clear of further scope-creep in the SolrClient interface (as described in SOLR-12502). # Tests N/A - still in "PoC" mode. # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org