gerlowskija commented on PR #2714: URL: https://github.com/apache/solr/pull/2714#issuecomment-2380057207
Alright, I've updated the PR to get rid of the thread-local which folks didn't like. For now the method is available on Http2SolrClient specifically - I'd love to see this spread to other "Http" clients eventually, but it's probably more work than it's worth currently. Next steps here: - some Javadoc wordsmithing for the new method(s) - add a SolrRequest-consuming method to cover the simple case as David requested on the JIRA ticket - add some tests, tidy, check. If everyone's OK with the overall approach at this point, I'll aim to get this in sometime in the near future and then start working on PRs to update all the places we currently use `SolrRequest.setBasePath`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
