gus-asf commented on PR #2666: URL: https://github.com/apache/solr/pull/2666#issuecomment-2375174745
This is now feeling complete, I'll be looking to commit it tomorrow afternoon or perhaps Friday morning to main if nobody objects or requests more time to review. I've had to back off any changes that mimic https://github.com/apache/solr/pull/2493 I had code for that, but I got lucky and hit a rare exception on one of my test runs, I found that ~1 in 20 times I was getting a CancellationException, and something less than 1 in 100 times (once it ran 800 iterations before failing) I was seeing a test fail where "omitted" was not properly reported with partialResults=false. I think I solved the CancellationException but ran out of time/energy to chase down whatever scenario was causing the rare test fail. Without that code (as the PR is now) I ran the CPU timeout test > 1500 times with no failures, so I'm confident that the problem is not transmitted in this PR, and additional enhancement can be done later. (I'll probably post a branch off of this branch showing what I had there for future reference). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
