dsmiley commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1778547978
########## solr/CHANGES.txt: ########## @@ -109,8 +109,11 @@ New Features Improvements --------------------- +* SOLR-17158: Users for whom partial results are uninteresting may set partialResultsAllowed=false. This allows Solr to reduce time spent processing partial results and omit them from the response. (Gus Heck, Andrzej Bialeki, hossman) Review Comment: If partial results are not allowed but the timeAllowed limit is reached, is the search effectively cancelled altogether then? I recall this has been the case with timeAllowed & partialResults=false param (`CommonParams.PARTIAL_RESULTS`) already. If this CHANGES.txt entry is trying to communicate the objective of this PR, I'm very confused and I think other users might be too, who I thought have already leveraged this behavior (or thought they were). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
