dsmiley commented on code in PR #2697:
URL: https://github.com/apache/solr/pull/2697#discussion_r1779120744
##########
solr/core/src/java/org/apache/solr/highlight/UnifiedSolrHighlighter.java:
##########
@@ -314,6 +343,24 @@ protected PassageFormatter getFormatter(String fieldName) {
return new DefaultPassageFormatter(preTag, postTag, ellipsis,
"html".equals(encoder));
}
+ @Override
+ protected Comparator<Passage> getPassageSortComparator(String fieldName) {
+ PassageSort passageSort =
+ PassageSort.parse(
+ params.getFieldParam(fieldName, HighlightParams.PASSAGE_SORT,
"startOffset"));
Review Comment:
could you instead reference the START_OFFSET.key instead of this constant
string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
