Seunghan-Jung commented on PR #2697: URL: https://github.com/apache/solr/pull/2697#issuecomment-2380663931
@dsmiley > Just a thought -- is this enum actually buying us anything at all? It's a bunch of lines of code but only ultimately used for a set lookup and nothing else? If so, lets just have less lines of code and do away with it. switch-case on String literals and null if no arg provided. The model I followed is the HighlightComponent.getHighlighter method. https://github.com/apache/solr/blob/34f77886104a15f9e478cf7b4a5f6b0691d79eb7/solr/core/src/java/org/apache/solr/handler/component/HighlightComponent.java#L174-L194 I adopted this approach. This is also why I trigger an AssertionError in the default case of the switch statement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
