mlbiscoc commented on code in PR #2734: URL: https://github.com/apache/solr/pull/2734#discussion_r1825971524
########## solr/api/src/java/org/apache/solr/client/api/model/ReplicationFileResponse.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.client.api.model; + +import jakarta.ws.rs.WebApplicationException; +import jakarta.ws.rs.core.StreamingOutput; +import java.io.IOException; +import java.io.OutputStream; + +public class ReplicationFileResponse extends SolrJerseyResponse implements StreamingOutput { + + public StreamingOutput dfs; + + public ReplicationFileResponse(StreamingOutput stream) { + this.dfs = stream; + } + + @Override + public void write(OutputStream outputStream) throws IOException, WebApplicationException { + dfs.write(outputStream); + } +} Review Comment: So instead of String, I found jax-rs supports [StreamingOutput](https://cxf.apache.org/docs/jax-rs-basics.html#JAXRSBasics-JAX-RSStreamingOutput:~:text=Response%20Streaming-,JAX%2DRS%20StreamingOutput,-StreamingOutput%20can%20be) but the code generation didn't like how it compiled just returning `StreamingOutput` without a `SolrJerseyResponse` so I went with this approach for now. This might look a bit hacky, but wasn't sure what other ways. Maybe there is an obvious fix here but lmk if this is or isn't right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
