dsmiley commented on code in PR #2734:
URL: https://github.com/apache/solr/pull/2734#discussion_r1844655213
##########
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java:
##########
@@ -1513,257 +1544,11 @@ public void postSoftCommit() {}
};
}
- /** This class is used to read and send files in the lucene index */
- private class DirectoryFileStream implements SolrCore.RawWriter {
Review Comment:
minor: as you are moving things and implementing a new interface, it's an
opportunity to consider the ordering of the methods follows a logical flow.
Disclaimer: I don't know this code enough to know what that is; it may be
ideal already. We like to read top-down generally so if it flows that way then
great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
