dsmiley commented on code in PR #2741:
URL: https://github.com/apache/solr/pull/2741#discussion_r1832773907
##########
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##########
@@ -223,15 +219,12 @@ private boolean fetchFileFromNodeAndPersist(String
fromNode) {
filedata.reset();
persistToFile(filedata, metadata);
return true;
-
- } catch (SolrServerException | IOException e) {
+ } catch (SolrServerException e) {
throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, "Error
fetching data", e);
+ } catch (IOException ioe) {
+ throw new SolrException(SERVER_ERROR, "Error persisting file", ioe);
Review Comment:
notice the needless lopsidedness in both throw statements. Use the import.
+1 to your changes today BTW.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
