dsmiley commented on code in PR #2741:
URL: https://github.com/apache/solr/pull/2741#discussion_r1906407989
##########
solr/core/src/java/org/apache/solr/cloud/Overseer.java:
##########
@@ -857,13 +857,18 @@ private void doCompatCheck(BiConsumer<String, Object>
consumer) {
return;
}
- try (CloudSolrClient client =
- new CloudHttp2SolrClient.Builder(
-
Collections.singletonList(getZkController().getZkServerAddress()),
Optional.empty())
- .withZkClientTimeout(30000, TimeUnit.MILLISECONDS)
- .withZkConnectTimeout(15000, TimeUnit.MILLISECONDS)
- .withHttpClient(getCoreContainer().getDefaultHttpSolrClient())
- .build()) {
+ try (var solrClient =
Review Comment:
@iamsanjay this is my only un-addressed comment. albeit minor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
