jdyer1 commented on code in PR #2899:
URL: https://github.com/apache/solr/pull/2899#discussion_r1889352673
##########
solr/core/src/java/org/apache/solr/security/HttpClientBuilderPlugin.java:
##########
@@ -34,4 +34,8 @@ public interface HttpClientBuilderPlugin {
public SolrHttpClientBuilder getHttpClientBuilder(SolrHttpClientBuilder
builder);
public default void setup(Http2SolrClient client) {}
+
+ public default void setup(Http2SolrClient.Builder httpClientBuilder,
Http2SolrClient client) {
Review Comment:
Yes, I agree separate methods would be nicer. But the implementing classes
do things on `setup` that should only be done once. I settled on this ugly
API with hopes this is the least-trappy thing to leave for future developers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
