dsmiley commented on code in PR #2899:
URL: https://github.com/apache/solr/pull/2899#discussion_r1890903610
##########
solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java:
##########
@@ -374,17 +374,13 @@ PublicKey fetchPublicKeyFromRemote(String nodename) {
}
}
- @Override
- public void setup(Http2SolrClient.Builder httpClientBuilder, Http2SolrClient
client) {
- setup(client, httpClientBuilder);
- }
-
@Override
public void setup(Http2SolrClient client) {
- setup(client, null);
+ setup(null, client);
}
- private void setup(Http2SolrClient client, Http2SolrClient.Builder builder) {
+ @Override
+ public void setup(Http2SolrClient.Builder httpClientBuilder, Http2SolrClient
client) {
Review Comment:
Suggest naming this param "builder" as it was, or "httpSolrClientBuilder".
Note "client" is simply "client".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
