dsmiley commented on code in PR #2919:
URL: https://github.com/apache/solr/pull/2919#discussion_r1892659835
##########
solr/solrj/src/java/org/apache/solr/common/MapWriter.java:
##########
@@ -70,8 +74,7 @@ public MapWriter.EntryWriter put(CharSequence k, Object v) {
writer.endObject();
}
- void writeMap(EntryWriter ew) throws IOException;
-
+ @Deprecated
Review Comment:
for an obscure method; I think we shouldn't burden ourselves with overly
helping likely non-existent users of such. Personally I do plenty of code
sleuthing to identify when lines of code are added/removed like a Deprecate or
whatever.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
