dsmiley commented on code in PR #2919:
URL: https://github.com/apache/solr/pull/2919#discussion_r1894685936
##########
solr/solrj/src/java/org/apache/solr/common/MapWriter.java:
##########
@@ -70,8 +74,7 @@ public MapWriter.EntryWriter put(CharSequence k, Object v) {
writer.endObject();
}
- void writeMap(EntryWriter ew) throws IOException;
-
+ @Deprecated
Review Comment:
> I did a pass the other week around deprecated code and a lot it wasn't
clear what would trigger the deleting of it.. Or how long it had been
deprecated.
Curious; in that instance, why did you care? In this case, it's just some
small utility method that any caller can do themselves. Thus the deprecation
rationale is not something I think any user would find interesting _for this
method_.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
