renatoh commented on code in PR #2932:
URL: https://github.com/apache/solr/pull/2932#discussion_r1909315295
##########
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##########
@@ -34,6 +35,8 @@
* serialized. It aims to minimize overhead and to be efficient at adding new
elements.
*/
public class SimpleOrderedMap<T> extends NamedList<T> {
+
+ private static final SimpleOrderedMap<Object> emptySimpleOrderedMap = new
SimpleOrderedMap<>(Collections.emptyList());
Review Comment:
" and doesn't import another class." Never thought of that advantages of
List.of over Collections.empty(). Good point, will adjust it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
