dsmiley commented on code in PR #2932:
URL: https://github.com/apache/solr/pull/2932#discussion_r1909380627
##########
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##########
@@ -67,4 +70,8 @@ public SimpleOrderedMap<T> clone() {
newList.addAll(nvPairs);
return new SimpleOrderedMap<>(newList);
}
+
+ public static SimpleOrderedMap<Object> emptySimpleOrderedMap() {
Review Comment:
Using `of` opens the door for some more static methods for more, which you
could add now if it makes `of` more attractive to you. Just a single pair
would be fine and perhaps useful. I look to the JDK for inspiration on data
structure conventions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
