dsmiley commented on code in PR #3158:
URL: https://github.com/apache/solr/pull/3158#discussion_r1943824313
##########
solr/core/src/test/org/apache/solr/search/facet/TestJsonFacets.java:
##########
@@ -4907,6 +4907,38 @@ public void testQueryJoinBooksAndPages() throws
Exception {
+ ", books2:{ buckets:[ {val:q,count:1}, {val:w,count:1} ] }"
+ "}");
}
+
+ @Test
+ public void testMultivalueEnumTypes() throws Exception {
+ final Client client = Client.localClient();
+
+ final SolrParams p = params("rows", "0");
+
+ client.deleteByQuery("*:*", null);
+
+ List<SolrInputDocument> docsToAdd = new ArrayList<>(6);
Review Comment:
Can you add them to an UpdateRequest so they are batched instead of sending
them individually? Same LOC in the end but avoids an anti-pattern. Or is the
separation pertinent to what's being tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
