dsmiley commented on code in PR #3158:
URL: https://github.com/apache/solr/pull/3158#discussion_r1948246532
##########
solr/core/src/java/org/apache/solr/search/facet/FacetField.java:
##########
@@ -139,11 +139,11 @@ public FacetProcessor<FacetField>
createFacetProcessor(FacetContext fcontext) {
// FieldType.getDocValuesType()
if (!multiToken) {
- if (mincount > 0 && prefix == null && (ntype != null || method ==
FacetMethod.DVHASH)) {
+ if (mincount > 0 && prefix == null && (isNumber || method ==
FacetMethod.DVHASH)) {
// TODO can we auto-pick for strings when term cardinality is much
greater than DocSet
// cardinality? or if we don't know cardinality but DocSet size is
very small
return new FacetFieldProcessorByHashDV(fcontext, this, sf);
- } else if (ntype == null) {
+ } else if (isNumber == false) {
Review Comment:
Maybe you are not familiar that Lucene & Solr has recognized this style as
acceptable due to its clarity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
