[
https://issues.apache.org/jira/browse/SOLR-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925319#comment-17925319
]
David Smiley commented on SOLR-16116:
-------------------------------------
Found another failure of BasicDistributedZk2Test with same symptoms
({{ZkController.onReconnect}})
[here|https://productionresultssa0.blob.core.windows.net/actions-results/8597700e-072f-403c-81cc-2a3fe8b3ee54/workflow-job-run-5264e576-3c6f-51f6-f055-fab409685f20/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-02-08T17%3A23%3A06Z&sig=sBJBpj3ndhpyUSkc1MWdukc5bBKJJ0YPYytcj4iMzOU%3D&ske=2025-02-09T04%3A56%3A25Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-02-08T16%3A56%3A25Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-01-05&sp=r&spr=https&sr=b&st=2025-02-08T17%3A13%3A01Z&sv=2025-01-05].
The onReconnect is registered as a listener, so not trivial to schedule to
ensure this happens before ZkController.close.
I'm thinking we may need a ReadWriteLock instead of isClosed in ZkController.
Any method that today checks isClosed would instead try to grab a read lock and
immediately give up if it can't (means ZkController is shutting down).
Acquiring the read lock will block close(); close() would grab the write lock
and never close it, as it signifies the final conclusion of ZkController. WDYT
[~houston]? I could take a stab at this.
> Refactor the Solr Zookeeper logic to use Apache Curator
> -------------------------------------------------------
>
> Key: SOLR-16116
> URL: https://issues.apache.org/jira/browse/SOLR-16116
> Project: Solr
> Issue Type: Sub-task
> Components: SolrCloud
> Reporter: Houston Putman
> Assignee: Houston Putman
> Priority: Major
> Labels: pull-request-available
> Fix For: main (10.0)
>
> Time Spent: 10h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
