mkhludnev commented on PR #2742:
URL: https://github.com/apache/solr/pull/2742#issuecomment-2469108428
Here's my idea:
- What's already done is fine and really needed, let's just add a refguide
section with a good example and go ahead with piggyback on
AggValueSourceParser.
Then, in another PR we may choose:
- plan B.1: introduce a new entity: FacetParser in solrconfig.xml and
/config api. That's doable, unless vetoed.
- plan B.2: introduce factory methods in FacetModule instead of
constructors' calls for all parsers and facets. And maybe even extract them
into a super factory for FacetModule. Then demo how users may to override the
standard FacetModule by own descendant extending a parsing routine. It let us
to stick with existing extensions/config system.
@timatbw, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
