HoustonPutman commented on PR #3037:
URL: https://github.com/apache/solr/pull/3037#issuecomment-2648778043
@dsmiley this broke
`ConcurrentUpdateSolrClientBuilderTest.testSocketTimeoutOnCommit()` in a fun
way. This PR works for all tests that extend `SolrTestCaseJ4`, because all of
those tests expect to have the SSLConfig configured by
`SolrTestCaseJ4.setupTestCases()`:
```java
sslConfig = buildSSLConfig();
// based on randomized SSL config, set SocketFactoryRegistryProvider
appropriately
HttpClientUtil.setSocketFactoryRegistryProvider(
sslConfig.buildClientSocketFactoryRegistryProvider());
```
Unfortunately, other tests, such as the one that is failing, extend
`SolrTestCase`, and expect to have the default SSLConfig configured by default
(a good assumption IMO). This test fails because the test ran before it extends
`SolrTestCaseJ4` and the randomization selected HTTPS for that run. After the
test succeeded, SolrTestCaseJ4 no longer reset the SSLConfig, and then
`ConcurrentUpdateSolrClientBuilderTest.testSocketTimeoutOnCommit()` tried to
connect to an HTTP endpoint using the HTTPS SSLConfig, which fails.
I think we should just revert this and keep the original logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
