dsmiley commented on PR #3037: URL: https://github.com/apache/solr/pull/3037#issuecomment-2649745240
Very impressive debugging Houston! Apparently I overlooked STCJ4.setupTestCases SSL stuff. Maybe I should undo the STCJ4 change (as you suggest), although I like the explicit changes to the 2 tests I also touched here. I ultimately want to be able to switch many tests extending STCJ4 to use SolrTestCase instead. But I don't want STC to become so bloated as STCJ4 is. Perhaps the SSL matters can be encapsulated into a TestRule. Oh I just noticed JettyConfig.Builder is referencing the public static field STCJ4.sslConfig -- _evil_! (separate but related issue; should raise to the dev list) I sense we'd have an easier time with randomization if we change our approach for some scenarios like SSL (also PRS, non-Overseer). Instead of flip-flopping from one test to the next, it'd be easier to track issues and debug if the entire build (all the tests selected) run a consistent SSL choice, and we either have a dedicated build or randomly choose this at the start. If it's the whole build, we'd then use Develocity tags, thus aiding tracking patterns. The choice could be determined in gradle and passed only when enabled. A failure would have a reproducer line showing the additional flags. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
