malliaridis opened a new pull request, #3184:
URL: https://github.com/apache/solr/pull/3184
# Description
After some CI runs we have noticed that the Kotlin multiplatform test tasks
of the new UI module, namely `allTests`, `desktopTest`, `wasmJsTest` and
`wasmJsBrowserTest`, are not excluded when we run `gradlew check -x test`.
# Solution
This PR explicitly disables the tasks if `test` is part of the
`excludedTaskNames`.
# Tests
You can test this issue by adding a failing test like below in the UI module
`commonTest`:
```kotlin
@Test
fun failingTest() {
fail("This test should always fail")
}
```
Without these code changes, you will notice that the tests are still
executed on `gradlew check -x test`. With the code changes, the tests should
not be executed.
Note that `gradlew check -x test --dry-run` will have the same output in
both cases, probably because the exclusion rule is not resolved at this point.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my
code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request
title.
- [x] I have given Solr maintainers
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
to contribute to my PR branch. (optional but recommended, not available for
branches on forks living under an organisation)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
