epugh commented on code in PR #3204:
URL: https://github.com/apache/solr/pull/3204#discussion_r1965992291
##########
solr/core/src/java/org/apache/solr/core/ZkContainer.java:
##########
@@ -87,7 +87,7 @@ public void initZooKeeper(final CoreContainer cc, CloudConfig
config) {
// TODO: remove after updating to an slf4j based zookeeper
System.setProperty("zookeeper.jmx.log4j.disable", "true");
- String solrHome = cc.getSolrHome();
+ String solrHome = cc.getSolrHome().toString();
Review Comment:
Just want to confirm that we are still stuck with String here? I see below
the `Paths.get`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]