mlbiscoc commented on code in PR #3204:
URL: https://github.com/apache/solr/pull/3204#discussion_r1966047995
##########
solr/core/src/java/org/apache/solr/core/ZkContainer.java:
##########
@@ -87,7 +87,7 @@ public void initZooKeeper(final CoreContainer cc, CloudConfig
config) {
// TODO: remove after updating to an slf4j based zookeeper
System.setProperty("zookeeper.jmx.log4j.disable", "true");
- String solrHome = cc.getSolrHome();
+ String solrHome = cc.getSolrHome().toString();
Review Comment:
If I am reading this right, this can be removed and the call below doesn't
need `Paths.get()` but can just be
`cc.getSolrHome().resolve(zoo_data).toString()`
##########
solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java:
##########
@@ -145,7 +145,7 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
rsp.add("zkHost",
getCoreContainer(req).getZkController().getZkServerAddress());
}
if (cc != null) {
- rsp.add("solr_home", cc.getSolrHome());
+ rsp.add("solr_home", cc.getSolrHome().toString());
Review Comment:
`toString()` might not be necessary here because of this
[textWriter](https://github.com/apache/solr/blob/d2fdb16a78195e5eb40caf48761afeb1bce041ee/solr/solrj/src/java/org/apache/solr/common/util/TextWriter.java#L78)
I think but this probably needs to be confirmed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
