dsmiley commented on code in PR #3163:
URL: https://github.com/apache/solr/pull/3163#discussion_r1966955662
##########
solr/solrj/src/java/org/apache/solr/common/util/Utils.java:
##########
@@ -290,7 +290,7 @@ public static Object fromJSON(byte[] utf8) {
}
public static Object fromJSON(byte[] utf8, int offset, int length) {
- return fromJSON(utf8, offset, length, STANDARDOBJBUILDER);
+ return fromJSON(utf8, offset, length, SIMPLEORDEREDMAPOBJBUILDER);
Review Comment:
This must be changed back; I don't think it makes sense to deserialize JSON
and get a SimpleOrderedMap in there. I debugged and the root of the problem is
that SimpleOrderedMap is not actually fully implementing the contract of a Map
with regards to equals & hashCode. I'll push some changes very soon. This
part should be extracted to it's own PR against the same issue of
SimpleOrderedMap implementing a Map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
