renatoh commented on code in PR #3163:
URL: https://github.com/apache/solr/pull/3163#discussion_r1953918318
##########
solr/solrj/src/java/org/apache/solr/common/util/Utils.java:
##########
@@ -290,7 +290,7 @@ public static Object fromJSON(byte[] utf8) {
}
public static Object fromJSON(byte[] utf8, int offset, int length) {
- return fromJSON(utf8, offset, length, STANDARDOBJBUILDER);
+ return fromJSON(utf8, offset, length, SIMPLEORDEREDMAPOBJBUILDER);
Review Comment:
Looking at a test case
ClusterStateProviderTest.testClusterStateProviderEmptySolrVersion,
Http2ClusterStateProvider is using JavaBinCode to deserialize, hence we get now
a SOM, ZkClientClusterStateProvider is using JSON and use the Utils.fromJson to
deserialize, and it still gets a LinkedHashMap. In this test it expects the
same data structure from both Http2ClusterStateProvider and
ZkClientClusterStateProvider, hence it's failing now.
If I change the Utils to return SMO instead of a LinkedHashMap, as I did in
this change, all the tests in ClusterStateProviderTest pass, but it breaks 17
other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
